[ 
https://issues.apache.org/jira/browse/SHINDIG-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eiji Kitamura updated SHINDIG-854:
----------------------------------

    Attachment: OAuthFix2.patch

I've examined serv...@name part once again, and found yoichiro is right.
Attached is a patch the wrong part is ommited.

> OAuth miscellaneous bugs
> ------------------------
>
>                 Key: SHINDIG-854
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-854
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadget Rendering Server (PHP)
>    Affects Versions: trunk
>            Reporter: Eiji Kitamura
>            Assignee: Chris Chabot
>            Priority: Trivial
>             Fix For: trunk
>
>         Attachments: OAuthFix.patch, OAuthFix2.patch
>
>
> 1) OAuth/Service needs to have "name" attribute. Current implementation isn't 
> complaining.
> 2) According to XSD, each url for OAuthServices (request, authorization, 
> access) isn't mandatory. Current implementation is assuming they are existing.
> 3) parseEndPoint had better trim its paramers.
> 4) Some parameters (OAuth/serv...@name, OAuth/Service/requ...@url, 
> OAuth/Service/acc...@url, OAuth/Service/authorizat...@url) are required but 
> not checked on current code.
> 5) OAuth param_location isn't conforming to the spec.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to