[ 
https://issues.apache.org/jira/browse/SHINDIG-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henning Schmiedehausen updated SHINDIG-860:
-------------------------------------------

    Attachment: SHINDIG-860-1.0.x.patch

patch for 1.0.x branch

> Shindig javascript feature code uses new opensocial.IdSpec but should not
> -------------------------------------------------------------------------
>
>                 Key: SHINDIG-860
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-860
>             Project: Shindig
>          Issue Type: Bug
>          Components: Features (Javascript)
>            Reporter: Henning Schmiedehausen
>         Attachments: SHINDIG-860-1.0.x.patch, SHINDIG-860-trunk.patch
>
>
> According to 
> http://www.opensocial.org/Technical-Resources/opensocial-spec-v081/opensocial-reference,
>  the right way to get a new IdSpec object is to use opensocial.newIdSpec
> However, the current javascript feature code uses  new opensocial.IdSpec, 
> which might upset IdSpecs if you need some sort of housekeeping. 
> The spec is unclear here and does not define whether it is legal or not to 
> directly instantiate opensocial.* objects directly and a gadget can obviously 
> still do this, but the reference code should be strict and use newIdSpec. The 
> attached patch changes all occurences to use the factory method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to