[ 
https://issues.apache.org/jira/browse/SHINDIG-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664773#action_12664773
 ] 

Tim Moore commented on SHINDIG-871:
-----------------------------------

Paul,

Your change allows building with Java 1.6, which is exactly what the original 
patch was trying to prevent in the first place! :-) I take it you were building 
with 1.6 and that's why it was failing on your system?

Per the discussion on shindig-dev[1] I think the only way to ensure that nobody 
commits changes that will break on 1.5 is to force all builds to be made with 
that version.

[1] http://markmail.org/message/oy7k4xq7n2xqttjg



> Shindig's Java build script should validate the correct Java version
> --------------------------------------------------------------------
>
>                 Key: SHINDIG-871
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-871
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Common Components (Java), Gadget Rendering Server 
> (Java), RESTful API (Java)
>    Affects Versions: trunk, 1.0.x-incubating
>            Reporter: Tim Moore
>         Attachments: maven-enforcer-plugin-SHINDIG-871.patch
>
>
> There have been a couple of cases where people checked in code that compiles 
> under Java 6 but not Java 5.
> The Maven enforcer plugin can be used to require a particular Java version or 
> range.
> http://maven.apache.org/plugins/maven-enforcer-plugin/rules/requireJavaVersion.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to