[
https://issues.apache.org/jira/browse/SHINDIG-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665261#action_12665261
]
Ian Boston commented on SHINDIG-874:
------------------------------------
The patch looks Ok, however can you tell me why you are using HSQLDB rather
then Derby to perform the tests.
You may not be aware that HSQL does not support READ_COMITTED transaction
isolation and so will not produce valid tests for anything that either relies
on or checks for correct transaction isolation. Since the project is JPA it
should not matter which DB is used and since this is an Apache project, I cant
see a reason not to use Derby.
Does that make sense ?
Could be a separate, patch, happy to do it.
> Restful integration tests for samples implementation of PersonService,
> ActivityService and AppDataService
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-874
> URL: https://issues.apache.org/jira/browse/SHINDIG-874
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Chico Charlesworth
> Attachments: fix-874-735677-improvement.patch
>
>
> Integration tests similar to those in the social-api module (i.e.
> org.apache.shindig.social.dataservice.integration unit tests) are needed
> whereby the samples implementation of PersonService, ActivityService and
> AppDataService are used instead.
> The integration tests should extend those in the social-api module so as to
> minimise code duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
