[
https://issues.apache.org/jira/browse/SHINDIG-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665658#action_12665658
]
Ian Boston commented on SHINDIG-878:
------------------------------------
Hmm,
1.
It maps to the Enum in the OS spec, just as all the other model classes do.
see
http://www.opensocial.org/Technical-Resources/opensocial-spec-v081/opensocial-reference#opensocial.Enum
2. (an observation)
There are plenty of other classes named Enum
org.apache.commons.lang.enum.Enum
org.apache.commons.lang.enums.Enum
com.sun.tools.java.code.Attribute.Enum
com.sun.jmx.snmp.agent.SnmpRequestTree.Enum
(and more)
but just because someone else uses Enum doent make it right.
3. we are not calling it java.lang.Enum, so strictly speaking it doesnt clash,
although it might be anoying to be forced to used the full package name of one
of them. There are plenty of names re-used in different packages.
IMHO 1 is important, 2 & 3 are just contributory factors, but *if* it should be
changed, then so (IMVHO) should the OpenSocial spec.
Having said that, you could argue the Java Social API implements the REST
protocol, and not the JS API, referenced above.
just my 2p.
> Please rename org.apache.shindig.social.opensocial.model.Enum
> -------------------------------------------------------------
>
> Key: SHINDIG-878
> URL: https://issues.apache.org/jira/browse/SHINDIG-878
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Reporter: Jordan Zimmerman
>
> Enum is a very bad choice for a class name as it clashes with the JDK class
> with the same name. Please rename
> org.apache.shindig.social.opensocial.model.Enum
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
