[
https://issues.apache.org/jira/browse/SHINDIG-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666204#action_12666204
]
David Citron commented on SHINDIG-671:
--------------------------------------
Tom,
You are correct! I created an "off by one" error with my prior fix.
Please take a look at the newly attached patch. I have reworked the solution in
a simpler fashion that does not mess with the argument order passed into
setUserPref.
Thanks,
Dave
> setUserPref problems in gadgets.js
> ----------------------------------
>
> Key: SHINDIG-671
> URL: https://issues.apache.org/jira/browse/SHINDIG-671
> Project: Shindig
> Issue Type: Bug
> Components: Sample container & Examples
> Environment: FireFox
> Reporter: David Citron
> Attachments: shindig-671.patch
>
>
> gadgets.IfrGadgetService.prototype.setUserPref appears to have multiple
> issues:
> 1) its callback registration looses the "this" pointer, causing JS errors
> (cannot find other methods in its object)
> 2) it does not handle the case where the gadget does not yet have prefs set
> (prefs undefined error)
> I will attach a patch that worked for me to resolve these issues. Please take
> a look and determine if the patch is correct or if perhaps some usage pattern
> of mine is causing the issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
