[
https://issues.apache.org/jira/browse/SHINDIG-879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Lindner resolved SHINDIG-879.
----------------------------------
Resolution: Fixed
Fix Version/s: trunk
Correct, this is a bug. Thanks for the patch!
> Undefined field being used. JS function not following pattern of other
> functions
> --------------------------------------------------------------------------------
>
> Key: SHINDIG-879
> URL: https://issues.apache.org/jira/browse/SHINDIG-879
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript)
> Reporter: Jordan Zimmerman
> Fix For: trunk
>
>
> Lines 492 and 493 of shindig/features/opensocial-reference/datarequest.js
> uses a variable named "fields". This is not defined. Elsewhere in the file a
> local variable is allocated that assigns "fields" to
> "opensocial.DataRequest.PeopleRequestFields". So, the function should be:
> opensocial.DataRequest.prototype.newFetchActivitiesRequest = function(idSpec,
> opt_params) {
> opt_params = opt_params || {};
> var fields = opensocial.DataRequest.PeopleRequestFields; // THIS LINE
> IS MISSING
> this.addDefaultParam(opt_params, fields.FIRST, 0);
> this.addDefaultParam(opt_params, fields.MAX, 20);
> return opensocial.Container.get().newFetchActivitiesRequest(idSpec,
> opt_params);
> };
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
