[
https://issues.apache.org/jira/browse/SHINDIG-765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chirag shah updated SHINDIG-765:
--------------------------------
Attachment: HttpClient3-BasicHttpFetcher.diff
Switched the implementation BasicHttpFetcher to use the apache commons
HttpClient3.
Couple notes:
Should I explicitly declare that commons-httpclient (3.1) as a dependency in
the pom.xml? mvn clean install works fine and it doesn't complain about
commons-httpclient not being listed as a dependency.
I've also noticed that HttpClient is used in other places without
commons-httpclient being declared in the pom.xml.
(org/apache/shindig/social/sample/service/SampleContainerHandler.java)
Please feel free to rip it apart!
> BasiHttpFetcher does not set a read timeout and connection timeout is
> hardcoded to 5 seconds(not configurable)
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-765
> URL: https://issues.apache.org/jira/browse/SHINDIG-765
> Project: Shindig
> Issue Type: Bug
> Components: Gadget Rendering Server (Java)
> Reporter: Praveen Neppalli Naga
> Attachments: HttpClient3-BasicHttpFetcher.diff,
> patch-BasicHttpFetcher.txt
>
>
> Is there any special reason why read timeout is not set and also the
> connection timeout is hard coded to 5 seconds and not configurable?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
