[
https://issues.apache.org/jira/browse/SHINDIG-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673588#action_12673588
]
Ian Boston commented on SHINDIG-918:
------------------------------------
Patch is good, with some minor whitespace issues which I am happy to fix.
Will apply.
> Change to PersonHandler to allow filtering of requests - 0.9 improvement
> ------------------------------------------------------------------------
>
> Key: SHINDIG-918
> URL: https://issues.apache.org/jira/browse/SHINDIG-918
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: trunk
> Reporter: Ben Smith
> Fix For: trunk
>
> Attachments: SHINDIG-918-improvement.patch
>
>
> Calls for single people (say, /people/@me/@self) should be filterable:
> http://opensocial-resources.googlecode.com/svn/spec/draft/REST-API.xml#standardQueryParameters
> Because PersonHandler calls PersonService.getPerson() for such requests,
> which doesn't accept CollectionOptions, the result can't be filtered. A patch
> in SHINDIG-904 solved this by changing the getPerson() method signature but
> after much discussion on the mailing list it was decided that a better
> solution would be to change PersonHandler to only call getPeople, and convert
> the RestfulCollection result to a single Person when calls for a single user
> are made (like, /people/@me/@self).
> Patch to follow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.