[ 
https://issues.apache.org/jira/browse/SHINDIG-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pan Jie updated SHINDIG-926:
----------------------------

    Attachment: 20090218.patch

Here are things I did in this patch:
1. removed & fixed several unittest to make it pass
2. fixed xml/atom converter and modified these 2 unittests.
3. I removed GadgetContext->instanceGadgetId GadgetContext->getGadgetId 
GadgetContext->setGadgetId because class GadgetId was deleted.
4. I changed GadgetFactory->fetchGadget from private to protected so that it's 
easy to be tested. See php/test/gadgets/GadgetTest.php for detail.

> XML/ATOM converter failure for appdata REST api
> -----------------------------------------------
>
>                 Key: SHINDIG-926
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-926
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>            Reporter: Pan Jie
>         Attachments: 20090218.patch
>
>
> When using appdata REST api, there are 2 fatal errors:
> Fatal error: Cannot use object of type DataCollection as array in 
> /var/www/html/shindig/php/src/social/converters/OutputAtomConverter.php on 
> line 116
> Fatal error: Cannot use object of type DataCollection as array in 
> /var/www/html/shindig/php/src/social/converters/OutputXmlConverter.php on 
> line 63
> It occurs only when format=xml or format=atom, format=json is ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to