[
https://issues.apache.org/jira/browse/SHINDIG-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674817#action_12674817
]
Adam Winer commented on SHINDIG-924:
------------------------------------
GadgetFeatureRegistry takes a list of feature directories that are processed in
order. This lets us have the default set of shindig features, and then overlay
a small number of changes in a second directory hierarchy.
Duplicating a feature name within any one feature directory would be a bug.
So, keeping a Set<String> of feature names within JsFeatureLoader.loadFiles()
and JsFeatureLoader.loadResources() would probably be a good thing, but doing
it at the entire feature registry level is excessive.
> Should not allow registration of two features with the same name
> ----------------------------------------------------------------
>
> Key: SHINDIG-924
> URL: https://issues.apache.org/jira/browse/SHINDIG-924
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Bob Evans
> Priority: Minor
> Fix For: trunk
>
> Attachments: fix-924-bug.patch
>
>
> It seems there is never a good reason to register two features with the same
> name. Actually, the code allowing it causes feature developers to make
> mistakes -- trust me. Throw an IllegalArgumentException if a second feature
> with the same name is registered.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
