[ 
https://issues.apache.org/jira/browse/SHINDIG-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674847#action_12674847
 ] 

Cassie Doll commented on SHINDIG-897:
-------------------------------------

One change that I think definitely needs to be pulled in is the removal of 
consumerSecret from OAuthEntry. If you've got all this code in progress Paul it 
should be very easy. The only place that fetches the field, 
OAuthAuthenticationHandler, should change to look like this:

    String consumerSecret = store.getConsumer(entry.consumerKey).consumerSecret;
    OAuthAccessor accessor = new OAuthAccessor(new OAuthConsumer(null, 
entry.consumerKey,
        consumerSecret, provider));

Pulling some of the servlet code into a Util class is probably a good task for 
later. That way containers can get some benefit without having to be locked 
into the servlet setup.

> Add 3-legged OAuth validation support for RESTful api
> -----------------------------------------------------
>
>                 Key: SHINDIG-897
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-897
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>            Reporter: Jacky Wang
>            Priority: Minor
>         Attachments: alternativeOAuth.patch, 
> supports-3-legged-oauth-validation.patch, 
> supports-3-legged-oauth-validation.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> RESTful API now supports 2-legged OAuth, and we'd like to see it supports 
> validation for requests issued by 3-legged OAuth client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to