[
https://issues.apache.org/jira/browse/SHINDIG-951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Chabot resolved SHINDIG-951.
----------------------------------
Nice catch! Fix's been committed to both the trunk and the 1.0.x tree, thanks
> setFieldImpl does not handle boolean false values
> -------------------------------------------------
>
> Key: SHINDIG-951
> URL: https://issues.apache.org/jira/browse/SHINDIG-951
> Project: Shindig
> Issue Type: Bug
> Components: PHP
> Affects Versions: trunk
> Reporter: Nagy Attila
> Fix For: trunk, 1.0.0-rc1, 1.0.x-incubating
>
> Attachments: shindig_person_field_impl.patch
>
>
> In php/src/social/model/Person.php the setFieldImpl method checks that the
> new value is not empty. Hoewer this is done with the operator ==, and this
> results in false values being replaced by null, so not sent at all.
> This breaks the setIsOwner() and setIsViewer() methods, and caused me fail
> multiple tests in the compliance test.
> I hope this change does not break anything else.
> Patch following...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
