[
https://issues.apache.org/jira/browse/SHINDIG-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679408#action_12679408
]
Adam Winer commented on SHINDIG-942:
------------------------------------
Three choices from simplest to most complex:
(1) bind(PipelinedDataPreloader.class).to(YourSubclass.class) in your own
module. Yes, you can bind concrete classes to subclasses.
(2) Take advantage of the factored-apart DefaultGuiceModule, which is now
just:
ExecutorService service = Executors.newCachedThreadPool();
bind(Executor.class).toInstance(service);
bind(ExecutorService.class).toInstance(service);
install(new ParseModule());
install(new PreloadModule());
install(new RenderModule());
install(new RewriteModule());
// We perform static injection on HttpResponse for cache TTLs.
requestStaticInjection(HttpResponse.class);
... and replace PreloadModule with your own.
(3) Use Guice 2.0 beta (which works with Shindig) and Modules.override() to
override the binding for List<Preloader>.
> Make PipelinedDataPreloader a default implementation instead of hard-coded
> --------------------------------------------------------------------------
>
> Key: SHINDIG-942
> URL: https://issues.apache.org/jira/browse/SHINDIG-942
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: trunk
> Reporter: Jordan Zimmerman
> Attachments: fix-942-bug.patch
>
>
> PipelinedDataPreloader is currently hard coded in DefaultGuiceModule. It
> should use @ImplementedBy as is the pattern with other implementations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
