[ 
https://issues.apache.org/jira/browse/SHINDIG-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679871#action_12679871
 ] 

Chris Chabot commented on SHINDIG-966:
--------------------------------------

Removing the decoding there actually broke the makeRequest servlet (invalid 
token errors), if you are getting errors because of multiple decodes, it's 
probably better to remove the decoding from the servlet that's giving you the 
problems, and not from the general context. I've rolled back the change

> token over-decoding
> -------------------
>
>                 Key: SHINDIG-966
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-966
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>    Affects Versions: trunk
>            Reporter: Dmitry Vorobyev
>            Assignee: Chris Chabot
>             Fix For: trunk
>
>
> ### Eclipse Workspace Patch 1.0
> #P gadget
> Index: 
> http://svn.apache.org/repos/asf/incubator/shindig/trunk/php/src/gadgets/GadgetContext.php
> ===================================================================
> --- 
> http://svn.apache.org/repos/asf/incubator/shindig/trunk/php/src/gadgets/GadgetContext.php
>  (revision 20842)
> +++ 
> http://svn.apache.org/repos/asf/incubator/shindig/trunk/php/src/gadgets/GadgetContext.php
>  (working copy)
> @@ -292,9 +292,6 @@
>      if (! isset($token) || $token == '') {
>        $token = isset($_POST['st']) ? $_POST['st'] : '';
>      }
> -    if (count(explode(':', $token)) != 6) {
> -      $token = urldecode(base64_decode($token));
> -    }
>      if (empty($token)) {
>        throw new Exception("Missing or invalid security token");
>      }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to