[jira] Created: (SHINDIG-968) Typo in GadgetFeatureRegistryTest.java

[Balaji Srinivasan (JIRA)]

Typo in GadgetFeatureRegistryTest.java 
---------------------------------------

                 Key: SHINDIG-968
                 URL: https://issues.apache.org/jira/browse/SHINDIG-968
             Project: Shindig
          Issue Type: Bug
          Components: Java
    Affects Versions: trunk
            Reporter: Balaji Srinivasan
            Priority: Trivial
             Fix For: trunk


In 
java/gadgets/src/test/java/org/apache/shindig/gadgets/GadgetFeatureRegistryTest.java
 line 63, you see the following code:

   List<String> deps = Lists.newLinkedList();
   if (deps != null) {
     deps.add(dep);
   }

I think this should instead be
   List<String> deps = Lists.newLinkedList();
   if (dep != null) {
     deps.add(dep);
   }

Otherwise if you call makeFeature with a null dep, a null object will
be added to deps (which is probably not what you want).


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.