[
https://issues.apache.org/jira/browse/SHINDIG-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Chabot resolved SHINDIG-1038.
-----------------------------------
Resolution: Fixed
Assignee: Chris Chabot
Works for me, applied and committed. Thanks for the report and patch!
> Query paremeters: lang, country did not passed in GadgetUrlRenderer
> -------------------------------------------------------------------
>
> Key: SHINDIG-1038
> URL: https://issues.apache.org/jira/browse/SHINDIG-1038
> Project: Shindig
> Issue Type: Bug
> Components: PHP
> Affects Versions: trunk
> Reporter: Dmitry Vorobyev
> Assignee: Chris Chabot
>
> Missed code copy-pasted from GadgetHrefRenderer.php
> ### Eclipse Workspace Patch 1.0
> #P shindig
> Index:
> http://svn.apache.org/repos/asf/incubator/shindig/trunk/php/src/gadgets/render/GadgetUrlRenderer.php
> ===================================================================
> ---
> http://svn.apache.org/repos/asf/incubator/shindig/trunk/php/src/gadgets/render/GadgetUrlRenderer.php
> (revision 769750)
> +++
> http://svn.apache.org/repos/asf/incubator/shindig/trunk/php/src/gadgets/render/GadgetUrlRenderer.php
> (working copy)
> @@ -44,6 +44,8 @@
> $features = explode(':', $forcedLibs);
> }
> $query .= $this->appendLibsToQuery($features);
> + $query .= '&lang=' . urlencode($lang = isset($_GET['lang']) ?
> $_GET['lang'] : 'en');
> + $query .= '&country=' . urlencode($country = isset($_GET['country']) ?
> $_GET['country'] : 'US');
> // code bugs out with me because of the invalid url syntax since we dont
> have a URI class to fix it for us
> // this works around that
> if (substr($query, 0, 1) == '&') {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
