Created a visual patch review out of this: http://codereview.appspot.com/88070
Looks fantastic. I had only one comment re: the computed-style integer extraction method. On Thu, Jun 25, 2009 at 2:36 PM, Benjamin McCann (JIRA) <[email protected]>wrote: > > [ > https://issues.apache.org/jira/browse/SHINDIG-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724311#action_12724311] > > Benjamin McCann commented on SHINDIG-1101: > ------------------------------------------ > > Looks good to me. I tested it a couple different ways and it seems to work > for anything I threw at it (in Chrome 2 and Safari 4). Thanks for patching > this! > > > gadgets.window.adjustHeight() fails to resize in Webkit-based browsers > > ---------------------------------------------------------------------- > > > > Key: SHINDIG-1101 > > URL: https://issues.apache.org/jira/browse/SHINDIG-1101 > > Project: Shindig > > Issue Type: Bug > > Components: Java > > Reporter: Michael Hermanto > > Attachments: shindig-1101-fix > > > > > > In Webkit-browsers, gadgets will only resize to a larger size, but not to > a smaller size. This works in other browsers. Under the current > implementation, when no explicit height is specified, > gadgets.window.adjustHeight() will try to determine the height based on > element's scrollHeight and offsetHeight. Webkit always picks the larger > value (after resize) and calculating based on these result in incorrect > (over-estimated) height. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
