[ 
https://issues.apache.org/jira/browse/SHINDIG-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Chabot resolved SHINDIG-1106.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1-RC1
         Assignee: Chris Chabot

Since it's a change that could have some impact on how the container behaves 
I'm hesitant to commit this to the stable (0.8 based) branch. Arguably broken 
but consistent > inconsistent and working 'sometimes' :)

However I did take another good look at how this is dealt with in the trunk 
(0.9) based version of php shindig, and implemented a proper fix there; One of 
the issues that I ran into is that curl strips out the http response text (so 
of the "http/1.1 200 OK" it only makes the '200' accessible, so to be able to 
mirror the http code correctly in the proxy response I've had to implement a 
http code -> status message lookup in the remote content fetcher.

With that modification in place mirroring the http code as shindig retrieved it 
is working as intended again.

Thanks for the report!

> ProxyHandler fetch/fetchJson methods always returns 404 on error
> ----------------------------------------------------------------
>
>                 Key: SHINDIG-1106
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1106
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>    Affects Versions: 1.1-M1
>            Reporter: Johan Euphrosine
>            Assignee: Chris Chabot
>             Fix For: 1.1-RC1
>
>         Attachments: proxyhandler-fetch-proper-error.patch
>
>
> ProxyHandler fetch/fetchJson methods always returns 404 on error, I believe 
> it should return proper http error code with error content instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to