[
https://issues.apache.org/jira/browse/SHINDIG-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Chabot resolved SHINDIG-1122.
-----------------------------------
Resolution: Fixed
Assignee: Chris Chabot
Hey Matthieu, thanks for the report!
I think the fix should be simple enough, I've gone and committed:
Index: php/src/gadgets/GadgetFactory.php
===================================================================
--- php/src/gadgets/GadgetFactory.php (revision 795031)
+++ php/src/gadgets/GadgetFactory.php (working copy)
@@ -241,6 +241,7 @@
$signedRequests[$key] = $request;
}
if (count($signedRequests)) {
+ $signingFetcherFactory = new
SigningFetcherFactory(Config::get("private_key_file"));
$remoteContent = new BasicRemoteContent(new BasicRemoteContentFetcher(),
$signingFetcherFactory);
$resps = $remoteContent->multiFetch($signedRequests);
foreach ($resps as $response) {
Could you please verify that it does indeed fix the issue?
> Fatal error on <Preload> with authz="signed"
> --------------------------------------------
>
> Key: SHINDIG-1122
> URL: https://issues.apache.org/jira/browse/SHINDIG-1122
> Project: Shindig
> Issue Type: Bug
> Components: PHP
> Affects Versions: 1.1-BETA1
> Environment: Shindig (PHP) trunk
> Reporter: Matthieu Huguet
> Assignee: Chris Chabot
>
> I encountered a fatal error while trying to make a signed preload request in
> a gadget
> <Preload href="http://my-local-url/"; authz="signed" />
> Fatal Error :
> Call to member function getSigningFetcher() on a non object in
> /home/www/shindig/src/common/sample/BasicRemoteContent.php
> The problem is in the fetchResources() function (
> src/gadgets/GadgetFactory.php ) :
> $remoteContent = new BasicRemoteContent(new
> BasicRemoteContentFetcher(), $signingFetcherFactory);
> $signingFetcherFactory is not defined.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
