[
https://issues.apache.org/jira/browse/SHINDIG-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Chabot resolved SHINDIG-1141.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.1-BETA2
Assignee: Chris Chabot
Patch LGTM, thanks for fixing that up!
While applying the patch I did have a few rejects on the OAuthFetcher class,
inspecting the results there shows that all the rejected chunks are function
doc line ending changes:
*** 61,69 ****
*/
protected $authToken;
- /**
* Parameters from makeRequest
- * @var OAuthRequestParams
*/
protected $requestParams;
--- 61,69 ----
*/
protected $authToken;
+ /**
* Parameters from makeRequest
+ * @var OAuthRequestParams
*/
protected $requestParams;
(there's a few pages of such messages, this is but one example).
PHP Shindig currently uses unix style line endings consistently, perhaps you
can tell netbeans to do the same for php files? I think that would probably fix
this
> Make BasicRemoteContentFetcher configurable
> --------------------------------------------
>
> Key: SHINDIG-1141
> URL: https://issues.apache.org/jira/browse/SHINDIG-1141
> Project: Shindig
> Issue Type: Improvement
> Components: PHP
> Reporter: Arne Roomann-Kurrik
> Assignee: Chris Chabot
> Priority: Minor
> Fix For: 1.1-BETA2
>
> Attachments: issue100052_1.diff
>
>
> BasicRemoteContentFetcher (BRCF) is a concrete implementation of the abstract
> RemoteContentFetcher class. In certain cases it would be useful to swap out
> BRCF (for example, to use something other than curl or for unit testing) but
> it is explicitly created in several areas of the codebase.
> The patch I am submitting (available for review at
> http://codereview.appspot.com/100052/show) makes BasicRemoteContentFetcher
> configurable in container.php. It:
> * Adds a new configuration parameter "remote_content_fetcher" which
> defaults to BRCF
> * Removes hardcoded references to BRCF in favor of initializing the class
> specified in the configuration
> * Cleans up some lines from src/gadgets/oauth/OAuthFetcher.php - I believe
> these had strange line endings (no text is changed)
> * Removes unneeded imports from
> src/gadgets/servlet/GadgetRenderingServlet.php and
> src/gadgets/servlet/MetadataServlet.php
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
