Refactor MakeRequestServlet and MakeRequestHandler into a utility class
-----------------------------------------------------------------------
Key: SHINDIG-1153
URL: https://issues.apache.org/jira/browse/SHINDIG-1153
Project: Shindig
Issue Type: Improvement
Components: PHP
Reporter: Arne Roomann-Kurrik
Priority: Minor
Attachments: issue105099_9.diff
The makeRequest implementation is currently tied directly into the
MakeRequestServlet class, meaning that makeRequest can't be easily reused for
classes which rely on making requests to remote servers (As a workaround, the
Data Pipelining implementation makes a HTTP request to the MakeRequest servlet,
which seems wrong). This restriction is currently blocking implementation of a
servlet to implement the backend for the osapi.http methods.
I'm attaching a patch which refactors most of the MakeRequest functionality
into a helper class which obtains its arguments from a parameter array, as
opposed to pulling the parameters directly from the $_GET and $_POST
superglobals (leaving the servlet and handler code to do this). I've also
added a few unit tests for the MakeRequest class.
Review at http://codereview.appspot.com/105099/show - this touches a lot of
things so I'd appreciate a sanity check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
