[
https://issues.apache.org/jira/browse/SHINDIG-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743102#action_12743102
]
Shuo-Peng Liao commented on SHINDIG-1154:
-----------------------------------------
I've created a code review: http://codereview.appspot.com/105105
Please help me to review my fix.
> Invoke RPC call only if the perfs changed in gadgets.Prefs.prototype.set and
> gadgets.Prefs.prototype.setArray
> -------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1154
> URL: https://issues.apache.org/jira/browse/SHINDIG-1154
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Reporter: Shuo-Peng Liao
> Attachments: fix-1154-bug.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Currently functions gadgets.Prefs.prototype.set and
> gadgets.Prefs.prototype.setArray in javascript/features/setprefs/setprefs.js
> always invoke RPC calls to update prefs without checking if the value is
> changed or not. It would be nice to reduce latency and server load to check
> before invoking RPC call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
