[ 
https://issues.apache.org/jira/browse/SHINDIG-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758421#action_12758421
 ] 

Paul Lindner commented on SHINDIG-1083:
---------------------------------------

lgtm, patch applied, keeping issue open until verified.


> SampleContainer uses Content-Type application/x-www-form-urlencoded, even 
> though Shindig Java disallows it
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1083
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1083
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java, Javascript 
>    Affects Versions: 1.1-BETA1
>         Environment: Efffects only the Java implmentation
>            Reporter: Rohit Rai
>            Priority: Minor
>         Attachments: issue120067_9.diff
>
>
> To support OAuth Content-Type - application/x-www-form-urlencoded is 
> explicitly disallowed in the Java implmentation.
> Read http://codereview.appspot.com/28042/show for details.
> While doing this, the effect on existing containers and samples which might 
> be using the content-type wasn't taken into detail. The samplecontainer 
> bundled in shindig is effected by this change.
> Line #117 in samplecontainer.js makes a call to the server -
>        sendRequestToServer('setstate', 'POST',
>            gadgets.io.encodeValues({
>                "fileurl" : stateFileUrl
>            }),
>            opt_callback);
> Which should be handled by SampleContainerHandler service, but gets
> blocked by ApiServlet and throws an error saying "Cannot use disallowed
> Content-Type application/x-www-form-urlencoded"
> These are the files effected -
> samplecontainer.html
> samplecontainer.js
> SampleContainerHandler.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to