[
https://issues.apache.org/jira/browse/SHINDIG-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771190#action_12771190
]
Benjamin McCann commented on SHINDIG-1190:
------------------------------------------
I found out why the if block was causing trouble for the original bug reporter.
It's because the prefs dialog updates hidden inputs when you check/uncheck a
boolean preference. Text fields are non-hidden, so reversing the if statement
isn't the right fix. We should instead remove the if statement.
> userprefs don't get saved
> -------------------------
>
> Key: SHINDIG-1190
> URL: https://issues.apache.org/jira/browse/SHINDIG-1190
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Christiaan Hees
> Assignee: Paul Lindner
> Priority: Trivial
> Fix For: 1.1-BETA4
>
> Attachments: test.html
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> At shindig/javascript/container/gadgets.js:639 in the handleSaveUserPrefs it
> makes this check:
> if (input.type != 'hidden')
> I think this should actually be:
> if (input.type == 'hidden')
> cause at the moment it actually skips all the relevant fields which results
> in prefs being empty and thus not getting saved.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
