[ 
https://issues.apache.org/jira/browse/SHINDIG-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805443#action_12805443
 ] 

Tim Wintle commented on SHINDIG-1273:
-------------------------------------

 * Do the appropriate (gadgets|shindig) have to be declared global in each 
javascript for linters? 
I'm not sure if they are actually linted or not, so it may not be an issue.

 * This change should be documented more thoroughly IMO (possibly in 
globals.js) - so people who write their own features can take advantage of it.

> Add 'globals' feature for javascript code
> -----------------------------------------
>
>                 Key: SHINDIG-1273
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1273
>             Project: Shindig
>          Issue Type: Improvement
>    Affects Versions: 1.1-BETA5
>            Reporter: Paul Lindner
>            Assignee: Paul Lindner
>             Fix For: 1.1-BETA6
>
>         Attachments: globals.diff
>
>
> In the javascript code base there are multiple places where global variables 
> gadgets/shindig are set.  We should set these once in a globals block and 
> then set a dependency for that feature.  This will insure that our top level 
> namespace is properly set up once and only once and make it easier to move to 
> the closure compiler in the future.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to