Hi,
I don't think it is a so good idea. The code is not so huge, and 90% of the
code will be in the common part (if not more), so I don't think it's so
useful to cut and complexify it.
I do not see what the shinken.plugin can be in fact, maybe this one can be a
good thing, but we won't redone all nagios plugins in the core, it's not the
goal. Only some major one for transport like nrpe or check_nt for speed
thing, but I do not think adding in the core the whole plugin thing is
useful nor a good idea. Unless a huge link with Shinken core I prefer having
another repository for this is someone want to write such plugins. Of course
for modules they can be on the core repository, because without it they are
useless.
Jean
2011/2/2 Grégory Starck <g.sta...@gmail.com>
> 2011/2/2 Hartmut Goebel <h.goe...@goebel-consult.de>
>
> Am 02.02.2011 15:27, schrieb Grégory Starck:
>> > personally I agree with Hartmut ; I was thinking for some time to that
>> > too in fact.
>> Thanks for your support :-)
>>
>
> just give it to me in return ! ;)
>
>
>> > I already just had finished(&pushed) splitting the "bin/shinken-*"
>> > files into new files within shinken/XXXdaemon.py but I think they
>> > could easily be moved to a subdir like "shinken/bin/" too ..
>> I was not talking about sub-directories, but about sub-packages, which
>> is quite a difference :-)
>>
>
> yes sorry I wrote too fast, was thinking sub-packages too ;)
>
>
>> So I do not suggest putting all the daemon code into a single
>> shinken/bin/... directory, but putting each of the daemons into a
>> package of it own. Together will all the stuff only this daemon uses.
>>
>
> agreed.
>
>
>
>> Example: Package "shinken.arbiter" will become file
>> "shinken/arbiter/__init__.py". So all the stuff belonging to arbiter
>> only will be in shinken/arbiter. Same for reactioner, poller, etc.
>>
>
> totally agreed.. leave that to me ; Jean if you are ok already with
> this ? if yes then I can continue on it..
>
>
> If someone wants to deploy a poller to a system then, he (ideally) only
>> put there shinken/common and shinken/poller. If we may introduce
>> namespace packages somewhen, this could even become something like
>>
>> easy_install shinken.poller shinken.plugins.oracle shinken.plugins.hpux
>>
>
> would be perfect !
> same could be done for packages (deb or rpm or whatever).
>
>
>
>> That's what I'm invisioning.
>>
>
> Having all different elements of something *clearly* separated can only be
> good point so we have to envision it :p
>
> greg.
>
>
>
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better
> price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
> _______________________________________________
> Shinken-devel mailing list
> Shinken-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/shinken-devel
>
>
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires
February 28th, so secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Shinken-devel mailing list
Shinken-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shinken-devel
