Le 24 avril 2011 15:24, Grégory Starck <g.sta...@gmail.com> a écrit :
> Hi guys,
>
> in attach a, quite, big patch that I made the last days ; as it's quite big
> I propose first as a patch to all you :
>
>
by the way I was asking myself:
for this kind of *big* patch/commit (I tried to split this big commit into
many/lot of simples commits but for this time I couldn't (or it would take
myself a lot of time :/) because of the way I've done it) :
would'nt it be good/better (than to send/get the patch/commit by mail) if we
would create a separate branch on the master repository for it. This to
suggest that the branch contains big change(s) and that it's actually better
to not directly merge within the master branch ; this to eventually limit
the risk of directly breaking lot of stuffs..
like here I would create a branch named "cleaner_default_values" or
something like that; and push into it.. so that anyone can fetch & checkout
it & so be able to easily review or test it on his own side..
also if anyone would notice something(s) not entirely correct with the big
patch / new branch by then he can also push other(s) commit(s) to it..
once most of us would have reviewed or tested a bit the branch and that we
feel it good then we would together agree to merge it in the master one..
wdyt ??
greg.
------------------------------------------------------------------------------
Fulfilling the Lean Software Promise
Lean software platforms are now widely adopted and the benefits have been
demonstrated beyond question. Learn why your peers are replacing JEE
containers with lightweight application servers - and what you can gain
from the move. http://p.sf.net/sfu/vmware-sfemails
_______________________________________________
Shinken-devel mailing list
Shinken-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shinken-devel
