Hi, this discussion started at <https://github.com/naparuba/shinken/commit/2ac67a4cbb370f41f1856c99f94ea28c05c1041f>. This commit removed 78 (nearly) redundant config files in test. Unfortunatly it also removes another file which triggers a regression.
Am 18.07.2012 07:43, schrieb Gabès Jean: > But such files do not have to be maintained. These files are redundant data, but no "information". They do not add anything to the understanding of the test-cases. Even more, they are hindering the understanding. One can't see the wood for the trees. I can't see any use in keeping these files. IMHO we should even go one step further and cut the configs into smaller "modules". So one can see what is really required for this test. And this will speed up testing, since only *required* stuff is loaded. As of now, the configs are more or less random, depending on which config the developer did choose as a basis for his new config. This leads to rubbish in the config. Eg. maintenance_period/shinken-specific.cfg loads 10 modules, but doe not need them for the tests. Same for host_missing_adress, timeperiod_inheritance, complex_hostgroups, bad_timeperiods, to name just a few. As you can see, my cleanup is not about maintaining configs, but about keeping them tidy. > So > keeping all N distinct configuration files is even a good thing for tests, > especially regression check. This would require the test-case to check the regression. :-) -- Regards Hartmut Goebel | Hartmut Goebel | h.goe...@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Shinken-devel mailing list Shinken-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/shinken-devel
