Le 09/11/2013 21:41, Sébastien Coavoux a écrit :
Well, the pep8 and pylint stuff was done age ago ;). As far as I
remember I was not able to catch everything I wanted. Maybe it's just
an option to add :)
Tell me what was your issue. I'm pretty sure you do not pep8 test anymore :)
For tests, it could be a good idea to put them (test_*.py files)
in a separated directories. It will avoid some issues like nose
reporting error for test "nose.failure.Failure.runTest".
Nose failure a related to a test issue usually (like a file missing or
an exception) I don't get how create another directory will fix it.
I need to double check, but, usually, this kind of error appeared when
nose if trying to run tests on a file (with a name starting with
testxxx) which is not a real test file.
So, if you put your tests in another directory, you will be sure nose
will only find real test files.
May be this could appeared for other reason, but, in my experience,
that's the common case. I quickly checked the 'tests' directory in
shinken source code. It is likely my guess is correct.
Usually you do not need to hack like __import_shinken. Simply set
PYTHONPATH=.. in your tests scripts.
I agree with that. It just something I did not spent time to modiy as
it is "working" :)
If I could find time for that next month, I will propose a patch to
simplify this.
The code coverage reports file in
"Shinken-Upstream-Commit-Short-Tests" and
"Shinken-Upstream-Daily-Full-Tests". Obviously this is not what
you intended to do. Running nosetest in the right directory, and
using --cover-package or similar option to nosetest report could
simplify this.
That's a good idea actually. The fact that the reporting should be
"merged" was not my first problem as the short tests are a part of the
full one.
Hmmm... this is not really clean.
Anyway, go on this path! That's cool.
Do you plan to use Gerrit also? Coupled with git(obviously) and
Jenkins, this is great for code quality!
I don't even know what gerrit is :D.
Gerrit is a tool for code review. It could be plugged with Jenkins to
automatically run code checks and tests for each proposed patch.
Reviewer can comment the patch and easily see if tests passed.
An example, on Lustre free software:
http://review.whamcloud.com/#/c/7995/
Thanks for your feedback, I'm not really a Jenkins expert so help is
welcome.
It could be great to catch you in the freenode shinken channel, I
think you can help me a lot on this subject ;)
I will be traveling for business purpose soon. Let's try do talk more
next month.
Aurélien
------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Shinken-devel mailing list
Shinken-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shinken-devel
