Hi,
On Wed, Feb 26, 2014 at 11:14 AM, Rémi Palancher <r...@rezib.org> wrote:
> [...]> yep, it's over complex for an easy task indeed.
>
> Cool, we all agree that setup.py is too complex!
>
Oh yes I'm more than agree! :D
In fact, if I'm not wrong, the current setup.py allow some specific build
with just config or just other part. We don't need so much things. We got
just 2 main usercase for setup.py :
* early adoter/tarball lover installation. We need to create some dir,
regexp few lines in the ini files (soon no more need), and chmod
shinken:shinken them
* packagers : quite the same with just the python lib in fact if I'm not
wrong, and maybe just some configirations files (just the cfg?)
But currently It's hard, very very hard to separate the two. I don't
understand the magic in the setup.py about the directory or variables.
That's really specific to distutils, and we don't need so much things. We
got a setup.cfg files with current arg (or even sys.argv args) and that's
all. We don't need sub-class for some poor regexp, cp and chown...
>
> [...]
> For particular early adopters or developer needs, it is not very hard
> to set up infrastructure to automatically build upstream
> rpm/deb/whatever packages at every commits or every nights. For that
> particular users, using last features would as simple as updating
> distribution packages.
>
I prefer to have a simple setup.py file and take time to code on features,
instead of building packages that won't be used by packagers for distro.
In fact for early adopters updates, a simple pip upgrade shinken or python
setup.py update will only update all .py files, and that's all. We don't
touch configuration as we don't break configuration files compat between
update (even a 1.4 configuration will work on 2.0, it's just that the
default module path will be /var/lib/shinken/modules). so not a big deal,
even with a setup.py. (a concise one :) )
>
> [...]
> OK but I can't get how you intend to significantly simplify the current
> setup.py logic _without_ removing all the included magical features.
> What's the plan?
>
But I'll remove all the magic :)
We got no choice there, we will have to mainly rewrite it. We did got a
simple but working setup.py in the 0.8 version if I'm not wrong, we will
take the god part of it and add the missing features we need (not a lot in
fact).
Was the acceptation of the setup.py enhancement pull-request an error? Yes,
and believe me, now I'll look closer at this part of the project :)
Jean
>
> --
> Rémi Palancher
> http://rezib.org
>
------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
Shinken-devel mailing list
Shinken-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shinken-devel
