My concern was that people would probably look at each peer directory in the examples project as a self-contained runnable application and could be really confused as to how the webstart one would work. Maybe not though - maybe I'm just thinking about it too much :)
On Fri, Feb 19, 2010 at 1:28 PM, Kalle Korhonen <[email protected]> wrote: > I considered that but didn't see it as too beneficial to make the > module hierarchy deeper. We would need to introduce a new parent pom > for spring module and put both the war and the jar modules underneath. > However, we only need the war to package it up as it'll contain the > jar module. Sure, spring-client cannot be run as a standalone sample > but I don't think it should be too confusing. If we prefer to move it > to it's own multi-module build we can do that later. > > Kalle > > > On Fri, Feb 19, 2010 at 10:07 AM, Les Hazlewood <[email protected]> wrote: >> I just realized that this module is a peer to the spring webapp that >> launches it via webstart. Shouldn't it be a module underneath a web >> project since it can't reside on its own without the webapp? Just >> trying to understand the reasoning... >> >> On Fri, Feb 19, 2010 at 9:21 AM, Les Hazlewood <[email protected]> wrote: >>> This is awesome, thanks! >>> >>> On Fri, Feb 19, 2010 at 2:25 AM, <[email protected]> wrote: >>>> Author: kaosko >>>> Date: Fri Feb 19 07:25:50 2010 >>>> New Revision: 911722 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=911722&view=rev >>>> Log: >>>> SHIRO-89: Sample Spring Application - WebStart won't launch >>>> - Refactor Spring sample client from Spring sample into its own module to >>>> make packaging & dependency management easier and simpler. Work in progress >>>> >>>> Added: >>>> incubator/shiro/trunk/samples/spring-client/ >> >
