Best practice - once you've created a new issue, refer to the issue in the thread it was discussed (the one you created is https://issues.apache.org/jira/browse/SHIRO-129). But thanks, I'll take a look at it though it might take me a couple of days to get to it.
Kalle On Tue, Jan 12, 2010 at 9:04 AM, Jean-Cédric Desrochers <[email protected]> wrote: > Okay... it's done. > > I'v put a zip with the integration source file and another zip with a test > BankService I made for the purpose of my proof of concept. > > I made the best effort to make the integration seamless. I read aspect's > documentation last week before jumping in the code... so it might not be > optimal. For example I decided to define the aspect using a normal java class > with aspectj's annotation: so that the source code can be compile using javac > (and not imposing the aspectj compiler or any IDE toolkit). > > Hope this will help the community! > > Regards, > J-C > > On 12-Jan-2010, at 11:31, Kalle Korhonen wrote: > >> On Tue, Jan 12, 2010 at 8:26 AM, Jean-Cédric Desrochers >> <[email protected]> wrote: >>> I'm ready to submit a zip file with the first draft of the aspectj >>> integration code... but I need some help here! >>> I'm not a registered user (which I think I need to be in order to create >>> something in JIRA). What's the best thing I should do: create an account or >>> send the files to someone that would create the JIRA issue for me? >> >> Create the account - it's quick and you need it anyway if you submit >> anything else to any other Apache project. >> >> Kalle >> >> >>> On 11-Jan-2010, at 10:55, Les Hazlewood wrote: >>> >>>> J-C, >>>> >>>> If you contribute a patch, can you ensure that you create a new child >>>> Maven module under the support directory? i.e. support/aspectj? >>>> >>>> Thanks, >>>> >>>> Les >>>> >>>> On Mon, Jan 11, 2010 at 10:48 AM, Les Hazlewood <[email protected]> >>>> wrote: >>>>> Hi J-C, >>>>> >>>>> This is a big +1 from me. I would love if you could contribute this >>>>> back to Shiro, as it is something I've worried about for a while, but >>>>> haven't had the time to work on personally. >>>>> >>>>> Could you please add what you've done in the form of a patch or .zip >>>>> attachment (or both if necessary) to a Jira issue? I'm very excited >>>>> to see what you've done! >>>>> >>>>> Thanks for offering to help - it is much appreciated! >>>>> >>>>> Best, >>>>> >>>>> Les >>>>> >>>>> P.S. Please join the dev list if you haven't already for any tech >>>>> discussions related to the submissions. >>>>> >>>>> On Mon, Jan 11, 2010 at 10:03 AM, Jean-Cédric Desrochers >>>>> <[email protected]> wrote: >>>>>> First of, I want to say that what you've done is great. I was looking >>>>>> for a framework to help me setup security in our platform and Shiro is >>>>>> exactly what I needed. It's a simple framework that do not pretend to >>>>>> perform everything for you and (best of all) it's "embeddable" in any >>>>>> situation. It does not provide built-in audits (which is a requirement I >>>>>> have), but I can easily do that myself using the events generated by the >>>>>> framework. >>>>>> >>>>>> In my case, the situation is not a web app and not a spring container. >>>>>> We want to perform authorization based on annotations for seamless >>>>>> development and integration. However I realized that it is not currently >>>>>> available for me... only spring-aop can do this for now. I looked in the >>>>>> forums and I found that I'm not the only one that want's to do that. >>>>>> >>>>>> So I decided to jump in and do what it needed to use aspectj for what I >>>>>> wanted to do (validating actions programmatically is not really an >>>>>> option for me). I currently have a prototype working and I need to work >>>>>> on the run-time now: integration of the compiler and/or the code weaving >>>>>> (in a seamless manner). But nonetheless, I thing it could be a great >>>>>> addition to Shiro. Would you guys be interested in a donation so that >>>>>> the community can benefit??? >>>>>> >>>>>> Regards, >>>>>> J-C >>>>> >>> >>> > >
