Pablo Sebastián Greco wrote: > Hi everybody, I think I've found a bug in shorewall-perl > putting this line in tcrules > > RESTORE 0.0.0.0/0 0.0.0.0/0 all - - - > 0 > correctly generates this > > -A tcpre -m mark --mark 0x0/0xffff -j CONNMARK --restore-mark --mask 0xff > > on shorewall-shell but on shorewall-perl, generates this > > -A tcpre -j CONNMARK --restore-mark --mask 0xff
The attached patch corrects the problem. Thanks! -Tom -- Tom Eastep \ Nothing is foolproof to a sufficiently talented fool Shoreline, \ http://shorewall.net Washington USA \ [EMAIL PROTECTED] PGP Public Key \ https://lists.shorewall.net/teastep.pgp.key
Index: Shorewall/Chains.pm
===================================================================
--- Shorewall/Chains.pm (revision 7962)
+++ Shorewall/Chains.pm (working copy)
@@ -1124,7 +1124,7 @@
{
my ($testval, $mask) = @_;
- return '' unless $testval and $testval ne '-';
+ return '' unless defined $testval and $testval ne '-';
my $invert = $testval =~ s/^!// ? '! ' : '';
my $match = $testval =~ s/:C$// ? "-m connmark ${invert}--mark" : "-m mark ${invert}--mark";
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
