On Mon, Jun 22, 2009 at 11:45:20AM -0700, Tom Eastep wrote: > That is completely untrue. The TOS column can contain a > <numeric-value>[/<mask>] just as the tcclasses file can. The optional > <mask> is currently undocumentated, unfortunately.
Well iptables does NOT accept --tos with anything other than the 5 standard values. --dscp does. > The problem with patches like this that only worry about the code is > that they are incomplete. > > - The patch doesn't update Shorewall/configfiles/tcrules > - The patch doesn't update manpages/shorewall-tcrules.xml > - The patch doesn't update manpages6/shorewall6-tcrules.xml > - The patch doesn't update docs/traffic_shaping.xml I was asking more for input on wether it seemed useful. Since I got no reply, I didn't think much about it for a while. It seemed useful to me given --tos doesn't do what I thought it would based on the shorewall documentation. > So when I get a patch like this, I'm not very enthusiastic to merge it > right into my tree. Especially this one which largely duplicates a > function that is already available (given that the DSCP field is a > sub-field of the TOS byte). Well what version of iptables do you use because mine certainly does not accept arbitrary tos values (it does in the tcclasses but not tcrules). -- Len Sorensen ------------------------------------------------------------------------------ Are you an open source citizen? Join us for the Open Source Bridge conference! Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250. Need another reason to go? 24-hour hacker lounge. Register today! http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org _______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
