On Sun, 27 Dec 2009 00:10:59 -0800 Keith Mitchell <[email protected]> wrote:
> I didn't see this in the archive list, but I believe line 1787 of
> /sbin/shorewall should read:
>
> if [ $# -eq 1 ] && usage 1; then
>
> instead of:
>
> [ $# -eq 1 ] && usage 1;
>
> I didn't do a complete debug though. Shorewall threw a:
>
> /sbin/shorewall: line 1791: syntax error near unexpected token `else'
> /sbin/shorewall: line 1791: ` else'
>
> When I ran a "shorewall check" before making the above-mentioned
> correction. It seems to run fine after the correction above was made.
The correct fix is to add this line after 1787:
if shorewall_is_started; then
>
> I couldn't find newer code in the SVN. Most recent branch and tags
> seem to be from the 4.2 series.
>
Since Shorewall 4.3, we have used GIT for SCM. The above-mentioned fix
is commit 90a6dbcb666026a24552b06e2a207e7d0ada1890
Thanks for the report, Keith. This is the first time that I've had a bug
report against a release that I haven't even announced yet :-)
-Tom
--
Tom Eastep \ When I die, I want to go like my Grandfather who
Shoreline, \ died peacefully in his sleep. Not screaming like
Washington, USA \ all of the passengers in his car
http://shorewall.net \________________________________________________
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
