Tuomo Soini wrote:
> commit 88447bfc7de8546b8d9dd5385534a6253783f3db causes following warning:
> 
> Use of uninitialized value in pattern match (m//) at
> /usr/share/shorewall/Shorewall/Config.pm line 1224, <IF> line 13.
> 
> Reverting that commit removes warning.
> 

Patch attached.

Thanks,
-Tom
-- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Config.pm b/Shorewall/Perl/Shorewall/Config.pm
index 242c275..09b18ff 100644
--- a/Shorewall/Perl/Shorewall/Config.pm
+++ b/Shorewall/Perl/Shorewall/Config.pm
@@ -1221,7 +1221,7 @@ sub copy2( $ ) {
 ################################################################################
 
 EOF
-	print $script $_ unless /^\s*$/;
+	print $script $_ if defined && ! /^\s*$/;
 
 	while ( <IF> ) {
 	    chomp;

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to