Switching between address families is not completely implemented. The filters generated are correct but address validation is broken.
Corrected by the attached patch. -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Tc.pm b/Shorewall/Perl/Shorewall/Tc.pm
index 65fa27b..579b2e2 100644
--- a/Shorewall/Perl/Shorewall/Tc.pm
+++ b/Shorewall/Perl/Shorewall/Tc.pm
@@ -1187,9 +1187,9 @@ sub process_tcfilters() {
while ( read_a_line ) {
if ( $currentline =~ /^\s*IPV4\s*$/ ) {
- $family = F_IPV4;
+ Shorewall::IPAddrs::initialize( $family = F_IPV4 ) unless
$family == F_IPV4;
} elsif ( $currentline =~ /^\s*IPV6\s*$/ ) {
- $family = F_IPV6;
+ Shorewall::IPAddrs::initialize( $family = F_IPV6 ) unless
$family == F_IPV6;
} elsif ( $currentline =~ /^\s*ALL\s*$/ ) {
$family = 0;
} elsif ( $family ) {
@@ -1198,15 +1198,15 @@ sub process_tcfilters() {
push @family, $family;
for ( F_IPV4, F_IPV6 ) {
- $family = $_;
+ Shorewall::IPAddrs::initialize( $family = $_ );
process_tc_filter;
}
- $family = pop @family;
+ Shorewall::IPAddrs::initialize( $family = pop @family );
}
}
- $family = pop @family;
+ Shorewall::IPAddrs::initialize( $family = pop @family );
}
}
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today http://p.sf.net/sfu/msIE9-sfdev2dev
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
