On 12/20/10 2:34 PM, Tom Eastep wrote: > On 12/20/10 1:23 PM, Steven Jan Springl wrote: >> Tom >> >> Using the same test config I used for the proxarp problem and replacing the >> last line of the providers file with: >> >> isp2 2 2 main ssp2:192.168.0.4 192.168.0.254 >> >> which generates the following iptables rule: >> >> -A routemark -i ppp2 -m mac --mac-source -j MARK --set-mark 0x2 >> >> which produces the following message: >> >> iptables-restore v1.4.10: Bad mac address "-j" > > Hmmm -- wonder what I can do to give a more informative error to a user > trying to configure multi-ISP through a single PPP interface. Can't do > it at compile time since a PPP interface can have an arbitrary name. > > I'll take a look...
This appears to be a general problem with multi-ISP through a single optional interface, regardless of type. The attached patch should work around it; please let me know. Thanks, -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Providers.pm
b/Shorewall/Perl/Shorewall/Providers.pm
index 002c60c..3b6f34c 100644
--- a/Shorewall/Perl/Shorewall/Providers.pm
+++ b/Shorewall/Perl/Shorewall/Providers.pm
@@ -18,7 +18,7 @@
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301 USA.
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MAS
02110-1301 USA.
#
# This module deals with the /etc/shorewall/providers,
# /etc/shorewall/route_rules and /etc/shorewall/routes files.
@@ -35,7 +35,7 @@ use strict;
our @ISA = qw(Exporter);
our @EXPORT = qw( setup_providers @routemarked_interfaces handle_stickiness
handle_optional_interfaces );
our @EXPORT_OK = qw( initialize lookup_provider );
-our $VERSION = '4.4_15';
+our $VERSION = '4.4_16';
use constant { LOCAL_TABLE => 255,
MAIN_TABLE => 254,
@@ -520,7 +520,13 @@ sub add_a_provider( ) {
if ( $optional ) {
if ( $shared ) {
- emit ( " error_message \"WARNING: Gateway $gateway is not
reachable -- Provider $table ($number) not Added\"" );
+ my $var = $providers{$table}{mac};
+
+ $var =~ s/^\$//;
+
+ emit ( " error_message \"WARNING: Gateway $gateway is not
reachable -- Provider $table ($number) not Added\"" ,
+ " $var=fe:ff:ff:ff:ff:ff" );
+
} else {
emit ( " error_message \"WARNING: Interface $physical is not
usable -- Provider $table ($number) not Added\"" );
}
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
