On Sun, 2011-07-24 at 15:15 +0100, Steven Jan Springl wrote:

> In the attached minimal config. the two Limit actions produce the following
> messages:
> 
> Use of uninitialized value in string eq 
> at /usr/share/shorewall/Shorewall/Chains.pm line 2347.
> 
> Use of uninitialized value in hash element 
> at /usr/share/shorewall/Shorewall/Chains.pm line 2676.
> 
> Use of uninitialized value in hash element 
> at /usr/share/shorewall/Shorewall/Chains.pm line 2676.

Steven,

The attached simple patch eliminates these diagnostics.

Thanks,
-Tom
-- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________

diff --git a/Shorewall/Perl/Shorewall/Chains.pm b/Shorewall/Perl/Shorewall/Chains.pm
index 9a18d07..94b18f8 100644
--- a/Shorewall/Perl/Shorewall/Chains.pm
+++ b/Shorewall/Perl/Shorewall/Chains.pm
@@ -1032,6 +1032,8 @@ sub push_irule( $$$;@ ) {
 	$ruleref->{jump}       = $jump;
 	$ruleref->{target}     = $target;
 	$ruleref->{targetopts} = $targetopts if $targetopts;
+    } else {
+	$ruleref->{target} = '';
     }
 
     if ( $comment ) {

Attachment: signature.asc
Description: This is a digitally signed message part

------------------------------------------------------------------------------
Magic Quadrant for Content-Aware Data Loss Prevention
Research study explores the data loss prevention market. Includes in-depth
analysis on the changes within the DLP market, and the criteria used to
evaluate the strengths and weaknesses of these DLP solutions.
http://www.accelacomm.com/jaw/sfnl/114/51385063/
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to