On Fri, 2011-08-26 at 13:53 -0700, Tom Eastep wrote:
> On Fri, 2011-08-26 at 20:55 +0100, Steven Jan Springl wrote: 
> > Tom
> > 
> > Issuing the command '/var/lib/shorewall/firewall disable eth1' produces the 
> > following message:
> > 
> > var/lib/shorewall/firewall: 38411: shorewal_is_started: not found
> 
> Crap -- added that test after I had completed testing enable/disable
> and, wouldn't you know it, there is a typo in it.

Just discovered another rather bad bug. The entries
in /etc/shorewall/routing_rules are being applied twice while those
in /etc/shorewall/routes are not being applied at all.

Patch attached.

-Tom
-- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________

--- Providers.pm.orig	2011-08-28 07:55:57.000000000 -0700
+++ Providers.pm	2011-08-28 07:56:08.000000000 -0700
@@ -942,8 +942,8 @@
 	emit "\n#\n# Add ${provider}'s Routes\n#\nadd_${provider}_routes() {";
 	push_indent;
 	
-	if ( @{$providers{$provider}->{rules}} ) {
-	    emit $_ for @{$providers{$provider}->{rules}};
+	if ( @{$providers{$provider}->{routes}} ) {
+	    emit $_ for @{$providers{$provider}->{routes}};
 	} else {
 	    emit 'true';
 	}

Attachment: signature.asc
Description: This is a digitally signed message part

------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management 
Up to 160% more powerful than alternatives and 25% more efficient. 
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to