On 02/06/2012 05:42 PM, Steven Jan Springl wrote: > If the following command is issued against the attached config: > > shorewall update -b /etc/shorewallT8 > > The following error messages are produced: > > Use of uninitialized value $to in hash element at > /usr/share/shorewall/Shorewall/Chains.pm line 1968. > > Use of uninitialized value $to in pattern match (m//) at > /usr/share/shorewall/Shorewall/Chains.pm line 1968. > > ERROR: Internal error in Shorewall::Chains::find_chain at > /usr/share/shorewall/Shorewall/Chains.pm line 1884
Steven, The attached patch works for me. Thanks, -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Compiler.pm b/Shorewall/Perl/Shorewall/Compiler.pm
index 40275c6..96865d6 100644
--- a/Shorewall/Perl/Shorewall/Compiler.pm
+++ b/Shorewall/Perl/Shorewall/Compiler.pm
@@ -791,7 +791,7 @@ sub compiler {
#
# Process the rules file.
#
- process_rules;
+ process_rules( $convert );
#
# Add Tunnel rules.
#
diff --git a/Shorewall/Perl/Shorewall/Rules.pm b/Shorewall/Perl/Shorewall/Rules.pm
index 2728d15..b051d51 100644
--- a/Shorewall/Perl/Shorewall/Rules.pm
+++ b/Shorewall/Perl/Shorewall/Rules.pm
@@ -2525,11 +2525,13 @@ sub classic_blacklist() {
#
# Process the BLRules and Rules Files
#
-sub process_rules() {
+sub process_rules( $ ) {
+ my $convert = shift;
+ my $blrules = 0;
#
# Generate jumps to the classic blacklist chains
#
- my $blrules = classic_blacklist;
+ $blrules = classic_blacklist unless $convert;
#
# Process the blrules file
#
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
