On 04/09/2012 12:35 PM, Steven Jan Springl wrote: > On Monday 09 Apr 2012 19:09:28 Tom Eastep wrote: >> On 04/09/2012 10:13 AM, Tom Eastep wrote: >>> On 04/09/2012 06:56 AM, Steven Jan Springl wrote: >>>> Rule: >>>> >>>> SHELL echo "#DROP fw wan tcp 80" >>>> >>>> produces the following error messages: >>>> >>>> /bin/sh: Syntax error: Unterminated quoted string >>>> ERROR: SHELL Script failed : /etc/shorewallT8/rules (line 15) >>> >>> Doesn't this happen on prior versions as well? >> >> The attached patch should correct this issue. > > Unfortunately the patch has not worked. The messages are still produced.
Steven, This 'bug' has been in the compiler for a long time. The attached patch (on top of the earlier one) corrects it. Thanks, -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Config.pm b/Shorewall/Perl/Shorewall/Config.pm
index 63a3445..51ce01c 100644
--- a/Shorewall/Perl/Shorewall/Config.pm
+++ b/Shorewall/Perl/Shorewall/Config.pm
@@ -2173,7 +2173,7 @@ sub read_a_line(;$$$$) {
# If this isn't a continued line, remove trailing comments. Note that
# the result may now end in '\'.
#
- s/\s*#.*$// if $strip_comments && ! /\\$/;
+ s/\s*#.*$// if $strip_comments && /[\\]\s*#.*$/;
#
# Continuation
#
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________ Shorewall-devel mailing list Shorewall-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/shorewall-devel
