On 09/13/2012 05:10 PM, Mr Dash Four wrote:
>> Problems corrected since Beta 3:
>>
>> 1)  Added some missing VARDIR handling to the installers to handle
>> the case where a new install is being done and root's
>> ~/.shorewallrc is pre-2.5.8.

> One other thing: in various places you have substituted
> VARDIR='${VARLIB}/${PRODUCT}' (which was pure nonsense as single
> commas are interpreted literally by bash with no variable
> substitution taking place) with VARDIR=${VARLIB}/${PRODUCT}. What
> happens if I have a space in VARLIB? The correct assignment should
> really be VARDIR="${VARLIB}/${PRODUCT}".
>

Indeed -- VARDIR='${VARLIB}/${PRODUCT}' was only appropriate in the 
configure programs and I copied it unchanged into the installers. My bad.

As I've stated before, there are many places in the code that break if 
one of these directories has a space in its name, and I will only spend 
what time that I have left on this earth worrying about that problem 
when I have absolutely nothing else to do.

-Tom
-- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________

------------------------------------------------------------------------------
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to