On 12/4/12 1:03 PM, Steven Jan Springl wrote:

> In the attached config. rule:
> 
> self(:)  all  all  udp  900
> 
> produces the following messages:
> 
> Use of uninitialized value $target in pattern match (m//) at 
> /usr/share/shorewall/Shorewall/Rules.pm line 1146, <$currentfile> line 4.
> 
> Use of uninitialized value $target in concatenation (.) or string at 
> /usr/share/shorewall/Shorewall/Rules.pm line 1148, <$currentfile> line 4.
> 

The attached patch seems to resolve the issue.

Thanks Steven,
-Tom
-- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Rules.pm 
b/Shorewall/Perl/Shorewall/Rules.pm
index ed08c85..8f7f3d2 100644
--- a/Shorewall/Perl/Shorewall/Rules.pm
+++ b/Shorewall/Perl/Shorewall/Rules.pm
@@ -1129,6 +1129,8 @@ sub merge_levels ($$) {
 
     my $target   = $subparts[0];
 
+    fatal_error "Missing ACTION" unless supplied $target;
+
     push @subparts, '' while @subparts < 3;   #Avoid undefined values
 
     my $sublevel = $subparts[1];

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to