> I see no requirement for @_loglevel and @_logtag and I really don't want > to expand the use of @... any more than is absolutely necessary. > The way I see it, there are at least 3 advantages when using '@' instead of '$':
1. Avoid possible clash of variables defined in "param" (I could define "_loglevel=OMG" for example) - this is bound to mess things up quite dramatically. If you confine the use of shorewall "system" variables to be specified with '@' instead of '$' that could be easily avoided and clashes in the way I just described will never happen. 2. It keeps things clean: '$' is used for all user-defined variables, while '@' is reserved for shorewall's own "system" variables - the separation is quite obvious. 3. The above is, in a way, "future-proof": when '@' is completely separate from '$', if/when you decide to expand these "system" variables, there won't be any clash with existing configurations (i.e. variables already defined in "param") in the way I described in 1 above. Currently, if I already have a variable in my param file called "_logtag", the upgrade won't work and I have to scratch my head to find out why my firewall is messed up. >> Would it be possible to choose these (i.e. use a custom-specified logtag >> for example) in the action itself? in other words, specify a >> custom/preset logtag as well as loglevel for both LOG as well as >> NFLOG/ULOG targets? >> > > Can you elaborate a bit? > Please ignore this - it was before I realised that $_logtag and $_loglevel can be altered and I could specify something like: ?SET _logtag "MyLog1" ?SET _loglevel "6" LOG # -j LOG --log-level 6 --log-prefix "MyLog1" ?SET _logtag "MyLog2" ?SET _loglevel "7" LOG # -j LOG --log-level 7 --log-prefix "MyLog2" > I'm okay with changing the name to IGNORE... > Thanks, that'll do. > Again -- I'm not keen on expanding the set of those variables without a > strong use case. > See above. ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
