On 12/27/2012 11:43 PM, Edy Corak wrote:
> Hi Tom,
>
> the compiler shows no errors, but after try to start / restart the firewall,
> Shorewall6-lite produces the following error:
>
> /etc/shorewall6-lite/state/firewall: line 1931: syntax error: bad function
> name
> /etc/shorewall6-lite/state/firewall: line 1931: syntax error: bad function
> name
>
> The start of line 1931 in firewall is
>
> #
> # Add Optional Interface pppoe-wan (0)
> #
> start_interface_pppoe-wan() {
> if [ -n "$SW_PPPOEWAN_2_IS_USABLE" ]; then
> > ${VARDIR}/undo_pppoe-wan_routing
>
> cat <<EOF >> ${VARDIR}/undo_pppoe-wan_routing
> case \$COMMAND in
> enable|disable)
> ;;
> *)
> rm -f ${VARDIR}/pppoe-wan.status
> ;;
> esac
> EOF
>
> if ! $IP -6 rule ls | egrep -q "32767:[[:space:]]+from all lookup
> (default|253)"; then
> qt $IP -6 rule add from all table 253 prio 32767
>
> fi
>
> echo 0 > ${VARDIR}/pppoe-wan.status
>
> if [ $COMMAND = enable ]; then
> progress_message2 " Optional interface pppoe-wan Started"
> fi
>
> else
> echo 1 > ${VARDIR}/pppoe-wan.status
> error_message "WARNING: Optional Interface pppoe-wan is not usable --
> pppoe-wan not Started"
> fi
> } # End of start_interface_pppoe-wan();
>
> If I disable pppoe-wan and use another interface, Shorewall6 produces the
> same error.
>
> ...
>
> In Shorewall6 4.5.9.3 there was no problem to test it.The defect was actually introduced in Shorewall 4.5.10 -- patch attached. -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Providers.pm b/Shorewall/Perl/Shorewall/Providers.pm
index c57710b..410b077 100644
--- a/Shorewall/Perl/Shorewall/Providers.pm
+++ b/Shorewall/Perl/Shorewall/Providers.pm
@@ -1281,8 +1281,8 @@ sub process_providers( $ ) {
#
for ( grep interface_is_optional( $_ ) && ! $provider_interfaces{ $_ }, all_real_interfaces ) {
#
- # TABLE NUMBER MARK DUPLICATE INTERFACE GATEWAY OPTIONS COPY
- $currentline = "$_ 0 - - $_ - - -";
+ # TABLE NUMBER MARK DUPLICATE INTERFACE GATEWAY OPTIONS COPY
+ $currentline = chain_base($_) ." 0 - - $_ - - -";
#
$pseudoproviders += process_a_provider(1);
}
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and much more. Get web development skills now with LearnDevNow - 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122812
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
