1. ADD(setname:flags) (same with DEL) does not work with sets containing
the "-" character (such sets are accepted by shorewall anywhere else):
rules
~~~~~
ADD(+mickey-mouse:dst,dst) $FW net
Gives me "ERROR: Expected ipset name (mickey-mouse)".
Hmmm - That rule compiles error-free for me; git shows that bug was
corrected in a commit on October 2 of last year.
The patch I am attaching is how I fixed this particular issue when
compiling shorewall.
Agreed. Change will be in Beta 4.
Thanks.
The above, though, gives me " ERROR: TARGET must be specified".
"Joining" the lines in IELOG using "\" did not have any effect (still
gives me an error).
If you code action.IELOG as follows, it works:
Damn, I tried every other conceivable (random) combination. Will test
this later tonight. Out of interest though, if I use the alternative
syntax in its entirety (with curly braces) would that still work?
You need the blank ?ELSE parts because of line continuation in the event
that arguments are omitted.
Got it.
Yep. General problem of inline actions invoked in sections other than
NEW. Patch RELATED.patch attached.
I'll test the other patch you attached later.
I'll respond to the other issues as time permits.
No problem.
--- a/Rules.pm 2013-01-04 17:18:05.000000000 +0000
+++ b/Rules.pm 2012-12-15 18:36:30.000000000 +0000
@@ -2096,7 +2137,7 @@
my ( $setname, $flags, $rest ) = split ':', $param, 3;
fatal_error "Invalid ADD/DEL parameter ($param)" if $rest;
- fatal_error "Expected ipset name ($setname)" unless $setname =~
s/^\+// && $setname =~ /^(6_)?[a-zA-Z][-\w]*$/;
+ fatal_error "Expected ipset name ($setname)" unless $setname =~
/^(6_)?[a-zA-Z][\-\w]*$/;
fatal_error "Invalid flags ($flags)" unless defined $flags &&
$flags =~ /^(dst|src)(,(dst|src)){0,5}$/;
$action = join( ' ', 'SET --' . $xlate{$basictarget} , $setname ,
$flags );
}
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel
