On 01/27/2013 08:52 AM, Steven Jan Springl wrote:
> The attached minimal config. produces the following error messages:
>
> ERROR: Internal error in Shorewall::Chains::new_chain at
> /usr/share/shorewall/Shorewall/Chains.pm line 1972 /etc/shorewall2A18/rules
> (line 23) at /usr/share/shorewall/Shorewall/Config.pm line 1205
>
> Shorewall::Config::fatal_error('Internal error in
> Shorewall::Chains::new_chain at /usr/share/...') called at
> /usr/share/shorewall/Shorewall/Config.pm line 1243
>
> Shorewall::Config::assert('') called at
> /usr/share/shorewall/Shorewall/Chains.pm line 1972
>
> Shorewall::Chains::new_chain('filter', '_fw2lan') called at
> /usr/share/shorewall/Shorewall/Rules.pm line 883
>
> Shorewall::Rules::finish_chain_section('HASH(0xac62830)',
> 'HASH(0xac62830)', 'ESTABLISHED,RELATED,INVALID,UNTRACKED') called at
> /usr/share/shorewall/Shorewall/Rules.pm line 1000
>
>
> Shorewall::Rules::finish_section('ESTABLISHED,RELATED,INVALID,UNTRACKED')
> called at /usr/share/shorewall/Shorewall/Rules.pm line 2612
>
> Shorewall::Rules::process_section('NEW') called at
> /usr/share/shorewall/Shorewall/Rules.pm line 2692
>
> Shorewall::Rules::process_rule() called at
> /usr/share/shorewall/Shorewall/Rules.pm line 2886
>
> Shorewall::Rules::process_rules(0) called at
> /usr/share/shorewall/Shorewall/Compiler.pm line 823
>
> Shorewall::Compiler::compiler('script', '/var/lib/shorewall/.start',
> 'directory', '/etc/shorewall2A18', 'verbosity', 1, 'timestamp', 0, 'debug',
> ...) called at /usr/share/shorewall/compiler.pl line 142
> The attached patch corrects that problem. Thanks Steven, -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
commit a3a90d8d2e6f60e7e9740e2ab59e0f56d1dc147f Author: Tom Eastep <[email protected]> Date: Sun Jan 27 10:08:02 2013 -0800 Correct section handling: - Correct typo (' INVALID' -> 'INVALID' ) - Don't jump to non-existent target in finish_chain_section() Signed-off-by: Tom Eastep <[email protected]> diff --git a/Shorewall/Perl/Shorewall/Rules.pm b/Shorewall/Perl/Shorewall/Rules.pm index eb41e09..2b018ee 100644 --- a/Shorewall/Perl/Shorewall/Rules.pm +++ b/Shorewall/Perl/Shorewall/Rules.pm @@ -896,7 +896,7 @@ sub finish_chain_section ($$$) { } if ( $twochains ) { - add_ijump $chainref, g => $target; + add_ijump $chainref, g => $target if $target; %state = (); last; } @@ -2616,7 +2616,7 @@ sub process_section ($) { finish_section ( 'ESTABLISHED,RELATED' ); } elsif ( $sect eq 'UNTRACKED' ) { @sections{'ALL','ESTABLISHED','RELATED', 'INVALID' } = ( 1, 1, 1, 1 ); - finish_section ( 'ESTABLISHED,RELATED, INVALID' ); + finish_section ( 'ESTABLISHED,RELATED,INVALID' ); } elsif ( $sect eq 'NEW' ) { @sections{'ALL','ESTABLISHED','RELATED','INVALID','UNTRACKED', 'NEW'} = ( 1, 1, 1, 1, 1, 1 ); finish_section ( 'ESTABLISHED,RELATED,INVALID,UNTRACKED' );
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d
_______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
