Tom Eastep wrote:
> On 4/22/13 6:27 PM, Dash Four wrote:
>   
>> Tom Eastep wrote:
>>     
>>> On 4/22/13 5:07 PM, "Dash Four" <mr.dash.f...@googlemail.com> wrote:
>>>
>>>  
>>>       
>>>> Anyway, I've just implemented individual "!" in the NFACCT statement by
>>>> hacking your Accounting.pm - I can attach a small patch for
>>>> review/inclusion if you are interested, but be aware that it does change
>>>> the syntax slightly in a sense that "!" needs to be specified for each
>>>> object within NFACCT() - "NFACCT(...)!" is no longer allowed.
>>>>     
>>>>         
>>> Sure -- send it along.
>>>   
>>>       
>> Attached - the above caveat applies though.
>>     
>
> This patch is relative to the Shorewall directory rather than the
> 'shorewall' directory (which is the git base directory). I can't apply
> it with 'git am'.
Yeah, apologies - I've made it based on the rpm root tree as I am 
building shorewall using rpmbuild.

>  I can apply the patch directly with 'patch' but it
> will look like my patch rather than yours.
That's fine - I don't remember including any signed-off-by signatures 
(it was a "plain" patch), so I am not really that bothered whether it 
comes "from me" or not - the most important thing for me is its 
functionality, that's all.

>  Or do you know a trick that I
> don't that allows such patches embedded in emails to be applied with
> 'git am' ?
>   
The only thing I could suggest is what you've already done - altering 
the email, but as I already pointed out above - I am not really that 
bothered if I am shown to be "the author" or not.


------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Shorewall-devel mailing list
Shorewall-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shorewall-devel

Reply via email to